search

nikitabobko / AeroSpace

AeroSpace is an i3-like tiling window manager for macOS
https://nikitabobko.github.io/AeroSpace/guide
MIT License
7.56k stars 124 forks source link

Allow specifying relative DFS index for focus command #682

Closed lynaghk closed 1 week ago

lynaghk commented 1 week ago

I also wanted dfs next/prev as discussed in https://github.com/nikitabobko/AeroSpace/issues/248.

I figured I could implement without adding additional flags or breaking backwards compatibility by having the parser look for an optional +/- suffix on the existing dfs-index argument. The next/previous behavior can be had via:

focus --dfs-index +1 focus --dfs-index -1

respectively.

As with my other PR, I haven't implemented any automated tests around this but would be happy to look into doing so if desired.

nikitabobko commented 1 week ago

Thanks for the idea, but I think it should be implemented as separate dfs-next|dfs-prev arguments as mentioned in the issue, feel free to submit a different PR

You also forgot to update the docs and shell completion