search

nikitakit / Kaleidoscope-ModifierLayers

Modifier key layers for Kaleidoscope
8 stars 3 forks source link

Upgrade to new plugin API #2

Open FrigoEU opened 6 years ago

FrigoEU commented 6 years ago

Hey,

I've been using this plugin and it's been working great for me so far! I wanted to upgrade my firmware to take advantage of this fix:

https://github.com/keyboardio/Kaleidoscope-HIDAdaptor-KeyboardioHID/commit/a4368f13e7a1b58ef7212147f4f0e1ced131ff75

Unfortunately, updating to the latest version of this library causes me to be forced to switch to the new API for Kalediscope plugins:

https://github.com/keyboardio/Kaleidoscope/blob/master/UPGRADING.md

This plugin is using the older style API. Are there plans to upgrade this? I have no C experience, so I can't do it myself. If nobody takes this up, I might jump into it at a later date, but it'll take quite some time for me to do it, time which I don't have at the moment.

nikitakit commented 6 years ago

Does the following version work for you? https://github.com/algernon/Kaleidoscope-ModifierLayers/tree/f/plugin-v2

kriber82 commented 6 years ago

Had the same problem the OP reported. The branch seems to work for me. Thanks.

FrigoEU commented 6 years ago

Sorry for the very late reply, but that branch works for me, thanks a bunch!

FrigoEU commented 6 years ago

@nikitakit Actually, it compiles, but the functionality itself doesn't seem to be working, it doesn't do anything anymore. I've tried to make sense of the code myself but I don't have the necessary C++ knowledge. I also tried the example .ino file you provided, but that also doesn't work.

FrigoEU commented 6 years ago

Got it working: My primary layer was being reported as "off", so I added Layer.on(PRIMARY) in my own config file.

malob commented 5 years ago

I've updated @algernon's version to work with the latest APIs, maybe work pulling those changes into this repo?