search

nikitakit / hydrogen-python

Python-specific plugin for hydrogen. Make Python coding in the Atom editor even more interactive!
https://atom.io/packages/hydrogen-python
MIT License
54 stars 20 forks source link

Variable Explorer cell height too high on vertical screen #13

Open kylebarron opened 6 years ago

kylebarron commented 6 years ago

It appears that there's a maximum number of rows that the Variable Explorer can have. So on a vertical high DPI monitor, the spacing between rows is too high. Would this be dealt with in styles/hydrogen-python.less? Inside the VariableExplorerRenderer class?

image

This is a gif of me dragging the bottom edge of the Atom window down to the bottom of the screen. The initial pixel width seems ideal regardless of Atom's window height. peek 2018-08-01 11-38

nikitakit commented 6 years ago

The behavior for this is specified in the javascript file, not the stylesheet.

I'm well aware that the rendering of the sidebar has many issues. Unfortunately, the third-party library I'm using hasn't made it easy for me to find a good parameter combination that works. It's possible to change the code so these display issues don't happen for tall windows, but then if you shrink the Atom window size the variable explorer will have scrolling and pages simultaneously, which is also far from ideal. Another issue to keep in mind is how the component reacts when an existing Atom window is resized.

I would appreciate any help in getting the rendering fixed, either by specifying better options or by finding a better library for rendering tables.

I do most of my programming in Python (rarely touching Javascript except when I need to fix something in hydrogen), so I'm not in the best position to know how to render tables using a web stack.

kylebarron commented 6 years ago

That's fair. I have no experience with web stacks, but I may do some exploring.