search

nikitakit / hydrogen-python

Python-specific plugin for hydrogen. Make Python coding in the Atom editor even more interactive!
https://atom.io/packages/hydrogen-python
MIT License
54 stars 20 forks source link

fix run-and-move-down error (fixes #16) #17

Closed mbroedl closed 5 years ago

mbroedl commented 5 years ago

Fixes #16. Changed an includes-statement to an actual comparison.

kylebarron commented 5 years ago

@mbroedl
This includes all your previous commits. I think you might need to rebase from master.

mbroedl commented 5 years ago

@kylebarron Thanks! I just realised that, but did not know how to do that so I faffed around a bit. Would this be fine or should I delete the PR and make a new one after having rebased? :/

kylebarron commented 5 years ago

I'm not completely sure... This can be a tricky part of git (you'll find a lot of results when googling git rebase help haha).

Especially since your changes are tiny, you can basically just do:

git clone https://github.com/nikitakit/hydrogen-python
cd hydrogen-python

Then make your changes again, then do

git remote add mbroedl https://github.com/mbroedl/hydrogen-python
git push mbroedl master -f

Note that the last command will overwrite the history on your master branch on Github. Alternatively, you could create a new branch, push the new change to a new branch of your repository on Github, and then make a new PR from the new branch.

I hope that makes sense?

kylebarron commented 5 years ago

I think you pulled Hydrogen and not hydrogen-python...

mbroedl commented 5 years ago

@kylebarron Haha, thanks!! :-O I was just wondering why i couldn't find the relevant line in the main.js