search

nikitakit / hydrogen-python

Python-specific plugin for hydrogen. Make Python coding in the Atom editor even more interactive!
https://atom.io/packages/hydrogen-python
MIT License
54 stars 20 forks source link

fix wrong run-and-move-down behaviour (#16) #18

Closed mbroedl closed 5 years ago

mbroedl commented 5 years ago

Fixes #16. Changed an includes-statement to an actual comparison.

(What an odyssey, thanks @kylebarron for your help!)

kylebarron commented 5 years ago

Git can definitely be confusing at first! Getting in the practice of using different branches can definitely help. For example, if you had put stuff before on a dev branch, you could've started a new run-and-move-down-dev branch now and it might've been easier. I still get tripped up on that too!

mbroedl commented 5 years ago

Good shout, I will try that next time! I'm probably just too busy with my own stuff, that I never considered the need for using branches, let alone doing PRs a lot. :/

kylebarron commented 5 years ago

I never used to use branches but they can really help! Now whenever I'm trying to implement almost any feature, no matter how small, I make a new branch for it

mbroedl commented 5 years ago

My current main purpose for using git is writing my dissertation. I wish it had distinguishable features. :D

mbroedl commented 5 years ago

This should be good now @nikitakit , sorry for this issue.

nikitakit commented 5 years ago

Thanks! I'll try to get a new release out soon.