nikitakit
commented
6 years ago In response to your first point: you're completely right that "update" should be a verb; machine learning systems do make mistakes.
The situation here is a bit worse than usual because there's a verb phrase (VP) with no verb inside, which makes no sense. The reason this happens is that benepar doesn't actually do part-of-speech tagging: all tags come from spaCy (or NLTK).
benepar doesn't do its own tagging because several recent parsing papers have found that neural network parsers can work better if you don't considering part-of-speech tagging at all. I'm thinking about how to address the parser/tagger mismatch, but that's still an area for future research.
In response to your edit: the way it's implemented span._.labels does not include part-of-speech tags, only span labels. Part-of-speech tags in spaCy are accessible using token.tag_ (e.g. if len(span) == 1: tag=span[0].tag_). You can also look at the code I posted in #2. Also, two children may have the same label, so your tree-to-dict conversion may lose nodes due to key collisions.
colingoldberg
I am not sure about the following - please clarify - or report a bug (?)
The text I am parsing: when a notification is received that a driver is available then update that fact in the database
Result from parse_string:
In it, I see that the word 'update' is marked as NN. Should it not be a verb?
[The following added later, after further exploration]
A test script (below) produces a dict that is missing the entry for the word "update" - I think because no label was available for the word.
Please excuse the naivete of the test - I am a newcomer to Python as well.
Note: spaces replaced by dots.
` import benepar import spacy from benepar.spacy_plugin import BeneparComponent nlp = spacy.load('en') nlp.add_pipe(BeneparComponent("benepar_en"))
doc = nlp("when a notification is received that a driver is available then update that fact in the database") sent = list(doc.sents)[0] print(sent._.parse_string)
def.get_children(parent): ..retdict.=.{} ..if.len(list(parent..children)).>.0: ....for.child.in.parent..children: ......print(child) ......try: ........if.len(list(child..labels)).>.0: ..........lab.=.list(child._.labels)[0] ..........print(lab) ..........child_dict.=.{"label":.lab,."text":.str(child)} ..........gc.=.get_children(child) ..........child_dict["children"].=.gc ..........ret_dict[lab].=.child_dict ......except.Exception.as.e: ...... pass ..return.ret_dict
gc = get_children(sent) print(gc) `
The following gc result was output:
{ "SBAR": { "label": "SBAR", "text": "when a notification is received that a driver is available", "children": { "WHADVP": { "label": "WHADVP", "text": "when", "children": {} }, "S": { "label": "S", "text": "a notification is received that a driver is available", "children": { "NP": { "label": "NP", "text": "a notification", "children": {} }, "VP": { "label": "VP", "text": "is received that a driver is available", "children": { "VP": { "label": "VP", "text": "received that a driver is available", "children": { "SBAR": { "label": "SBAR", "text": "that a driver is available", "children": { "S": { "label": "S", "text": "a driver is available", "children": { "NP": { "label": "NP", "text": "a driver", "children": {} }, "VP": { "label": "VP", "text": "is available", "children": { "ADJP": { "label": "ADJP", "text": "available", "children": {} } } } } } } } } } } } } } } }, "ADVP": { "label": "ADVP", "text": "then", "children": {} }, "VP": { "label": "VP", "text": "update that fact in the database", "children": { "NP": { "label": "NP", "text": "that fact", "children": {} }, "PP": { "label": "PP", "text": "in the database", "children": { "NP": { "label": "NP", "text": "the database", "children": {} } } } } } }Note: Word "update" is missing.Colin Goldberg