search

nikitasavinov / checkstyle-action

Run Java checkstyle with reviewdog in github actions
MIT License
59 stars 37 forks source link

Fix for Git v2.35.2 spec changes #32

Closed JohNan closed 2 years ago

JohNan commented 2 years ago

The GitHub Actions fails Due to Git v2.35.2 spec changes.

Fixes error thrown by reviewdog

reviewdog: PullRequest needs 'git' command: failed to run 'git rev-parse --show-prefix': exit status 128

See https://github.com/reviewdog/reviewdog/issues/1158 for more info

Justintime50 commented 2 years ago

We are in need of this fix too as our GitHub Action broke. An alternative would be to pin the git version installed in the Dockerfile to avoid another regression like this.

nikitasavinov commented 2 years ago

Thank you for the quick fix! Merged and briefly checked. Please let me know if the issue persists.

Justintime50 commented 2 years ago

@nikitasavinov thanks for merging this! Are you able to cut a new release to include this? We don't use latest and instead pin all our dependencies including the version of this GitHub Action (which is currently pinned to v0.5.0)

nikitasavinov commented 2 years ago

Absolutely - in fact, it's already done!

Justintime50 commented 2 years ago

Fantastic, this did the trick for us. Thank you!