Add fail_on_error option

nikitasavinov / checkstyle-action

Run Java checkstyle with reviewdog in github actions

MIT License

59 stars 36 forks source link

Add fail_on_error option #8

Closed plata closed 4 years ago

nikitasavinov commented 4 years ago

Thanks for the contribution!

plata commented 4 years ago

You're welcome. It's only copy+paste (including the typo) from the official reviewdog actions (apparently they've added some options). Will there be a new release including this (and maybe #9)?

nikitasavinov commented 4 years ago

Yep, I will publish the new release (including #9 indeed) tomorrow

plata commented 4 years ago

By the way: it looks like reviewdog eventually got tired of adding options one by one and added one "reviewdog options" (to rule them all). Not sure if you would like to have that as well.