Closed nullswan closed 1 year ago
@nikitastupin Please, highlight changes your disagree with. Suggest the features you wants, I'll work on the todos.
Hey @c3b5aw,
Thank you very much for the PR. I've skimmed the changes and left few comments. Other than that we're good.
Regarding further feature requests, I suggest to merge this one as soon as possible (after finishing the ToDo of course) and then add things iteratively (it's much easier and faster to review small PRs). Would you be willing to proceed this way?
I can go through existing Issues and Pull Requests, de-duplicate and close stale ones so that we'll know what to focus on next.
Hey @c3b5aw,
Thank you very much for the PR. I've skimmed the changes and left few comments. Other than that we're good.
Regarding further feature requests, I suggest to merge this one as soon as possible (after finishing the ToDo of course) and then add things iteratively (it's much easier and faster to review small PRs). Would you be willing to proceed this way?
I can go through existing Issues and Pull Requests, de-duplicate and close stale ones so that we'll know what to focus on next.
Agreed
Thank you! I'm going to review and merge closer to the end of this week.
Seems to work fine with exception of publishing to PyPI - the "clairvoyance" name is already claimed. I've filled the details at https://github.com/nikitastupin/clairvoyance/issues/42 and probably will start solving it next week.
Changes
Repo structure
Docker
Workflows
cd.yml
${{ secrets.PYPI_TOKEN }}
to be set.test.yml
Code
ToDo