nikitastupin / clairvoyance

Obtain GraphQL API schema even if the introspection is disabled
Apache License 2.0
968 stars 87 forks source link

Clairvoyance v2.0.0 - Package, Async, Linting #40

Closed nullswan closed 1 year ago

nullswan commented 1 year ago

Changes

Repo structure

Docker

Workflows

cd.yml

test.yml

Code

ToDo

nullswan commented 1 year ago

@nikitastupin Please, highlight changes your disagree with. Suggest the features you wants, I'll work on the todos.

nikitastupin commented 1 year ago

Hey @c3b5aw,

Thank you very much for the PR. I've skimmed the changes and left few comments. Other than that we're good.

Regarding further feature requests, I suggest to merge this one as soon as possible (after finishing the ToDo of course) and then add things iteratively (it's much easier and faster to review small PRs). Would you be willing to proceed this way?

I can go through existing Issues and Pull Requests, de-duplicate and close stale ones so that we'll know what to focus on next.

nullswan commented 1 year ago

Hey @c3b5aw,

Thank you very much for the PR. I've skimmed the changes and left few comments. Other than that we're good.

Regarding further feature requests, I suggest to merge this one as soon as possible (after finishing the ToDo of course) and then add things iteratively (it's much easier and faster to review small PRs). Would you be willing to proceed this way?

I can go through existing Issues and Pull Requests, de-duplicate and close stale ones so that we'll know what to focus on next.

Agreed

nikitastupin commented 1 year ago

Thank you! I'm going to review and merge closer to the end of this week.

nikitastupin commented 1 year ago

Seems to work fine with exception of publishing to PyPI - the "clairvoyance" name is already claimed. I've filled the details at https://github.com/nikitastupin/clairvoyance/issues/42 and probably will start solving it next week.