search

nikitastupin / clairvoyance

Obtain GraphQL API schema even if the introspection is disabled
Apache License 2.0
960 stars 87 forks source link

[CD] Make single source of truth for the version #89

Open Privat33r-dev opened 2 months ago

Privat33r-dev commented 2 months ago

Currently to update version using CD 2 commands are required:

git tag v2.0.1 main
git push origin v2.0.1

But it causes issues when versions are desynchronized. For example as in this commit: label version is 2.5.3, while the pyproject.toml version is 2.5.2.

Since it's required to have a version in pyproject.toml and it's not flexible, while git tag is optional, I suggest to take version from pyproject.toml and apply it as a git tag. It can be done in github actions, but it would require some workarounds. It's most easily done via git hooks, but they are not automatically shareable for good reasons.

It will allow us to avoid desync issues and streamline version bump for new, as well as existing, contributors.

Privat33r-dev commented 2 months ago

@SnoozeThis https://github.com/nikitastupin/clairvoyance/pull/97

SnoozeThis commented 2 months ago

(https://snoozeth.is/eHS7n_Q_l_s) I will wait until https://github.com/nikitastupin/clairvoyance/pull/97 is merged and then add a comment.