search

nikitavoloboev / gitupdate

Commit and push updated files with file names as commit message
MIT License
105 stars 9 forks source link

`Exit status 1` for dotfile #9

Closed bowernite closed 3 years ago

bowernite commented 3 years ago

To reproduce

  1. Make change to file with path .zshrc (i.e., in root of git repo)
  2. $ gitupdate

Result:

2020/12/16 19:09:56 exit status 1
nikitavoloboev commented 3 years ago

I need to add some error catching. Not sure what caused this error to happen. The command will essentially git add ., git commit -m .. (with file names) and git push.

If you try run it yourself and see if any of the commands throws error, you will know the cause. Sometimes it's due to git .lock file being present.

bowernite commented 3 years ago

I think the problem is the logic here, where it's trying to strip the filename extension. For a file that starts with . like .zshrc, there's going to be nothing left for that part of the commit message, which is what I would imagine is causing the problem.

Not sure on the solution -- maybe just strip any leading periods off of filenames before doing that logic.

Happy to submit a PR at some point, but to be honest I have no idea what I'm doing in Go and might not have time soon to learn it.

nikitavoloboev commented 3 years ago

I'll try it out, thanks. Go is simple (https://news.ycombinator.com/item?id=25646909).

I'll try fix this soonish, if not, I am open to PR :)