iliantrifonov
commented
7 years ago - In the Engine class, row 52 you are missing an empty line after a closing bracket.
- In the Engine class, in ExecuteDisplayingStrategy, you have a very long statement inside of the Console.WriteLine. Refactor it so it is easier to read.
- In the Engine class use String.Format, instead of string everywhere, for consistency, as this is how the original code is written. This goes for the whole solution.
- In the Driver class on lines 71 & 86 you are missing an empty line after a closing bracket of an if/else statement.
- In the RaceTrack, Driver, Motor, MotorVehicle, Tunning classes you do not need to call : base() constructor of the IdentifiableObject (test this for yourself).
- In the RaceTrack class on line 82 you are missing an empty line after a closing bracket of an if/else statement.
- For all classes that you are modifying, methods and properties should have a line between them.
- You do not need to refactor this, but most places where they put in getter properties and NotImplementedExceptions, you could just have gone with an auto property, with a private setter. In most cases there is no use for you to have a field and a property that points to it, unless you have validation on set or custom logic on get. In many cases you do not.
- In the IntercoolerType, TransmissionType, TurbochargerType enums, you have placed a value (0) only on one of the options. Place a value on all or none. Enums inherit int, so default value of the 1st item is always 0.
- For all classes where you are using a private constant, you do not need to write the name of the class before the constant name, because it is private. Also you do not need to use the name of the class as part of the name of the constant. Since you have done these 2 things differently in different classes you have created, refactor it, so it is all consistent. I recommend either directly writing the name of the constant, or using the {class} . {name of the constant}. Don't use the name of the class as part of the constant name, as it is already inside of the class. Or you could also extract them in a constants class if you want to have the name of the class as part of the name of the constant.
You are provided with a project (zip file in this comment). Complete the project as described in the attached document.
Do not add the project to the Learning.sln. Have it be separate, but in the same folders. Commit the project before your changes initially, then in separate commits make your own changes. Instructions FastAndFurious.zip FastAndFurious - Skeleton.zip