nikivanov / watney

Watney is a low-cost 3D-printable FPV rover
GNU General Public License v3.0
378 stars 39 forks source link

Use Docker #36

Closed eerison closed 9 months ago

eerison commented 9 months ago

Hi @nikivanov

I was wondering... have you considered to use docker instead of packer? Why?

nikivanov commented 9 months ago

Hey @eerison!

The code uses pigpio which only works with raspberry pis from what I know, so making Watney more board-agnostic would involve more than just a docker image. Beyond that, I simply didn't see any advantage to using docker - it may not require extra compute, but it certainly wouldn't make the code more performant than running the process natively.

That being said, feel free to try it yourself and if it works, please open a PR and I can provide the docker image in addition to the native SD card image.

eerison commented 9 months ago

I see, I am not saying that docker gonna be more performing, but the current image just works for raspberry...

Just to know, do you have any suggestion , to make the project works for more boards? Like banana pi or orange pi

eerison commented 9 months ago

An regarding for pigpio , is it used just to integrate with pins, or is it used for something else?

Is it used in one place, or many places in the code?

And do you think pigpio is the biggest impediment?

I was thinking to use armbian, maybe it could be an alternative to support different boards

nikivanov commented 9 months ago

PIGPIO, raspivid, googlevoicehat-soundcard are all raspberry pi native, to name a few.

The board would also have to support hardware video encoding, I2C, SPI and I2S. OrangePi might support all that but it'd be a good amount of work to make Watney board-agnostic