search

nikivanov / watney

Watney is a low-cost 3D-printable FPV rover
GNU General Public License v3.0
384 stars 39 forks source link

Feature play audio #39

Closed eerison closed 11 months ago

eerison commented 11 months ago

Hey @nikivanov

I am adding a feature to play audio from sd card.

I am using the lib mpg123 my-audio.mp3, could I add this lib into the project? if yes I will provide a PR ;)

nikivanov commented 11 months ago

You can add whatever libraries you want to your local project - you don't need my permission to do so. If I were you I'd go with using gstreamer to play the mp3 since it's already installed, but either would work.

On Mon, Oct 30, 2023, 9:27 AM Erison Silva @.***> wrote:

Hey @nikivanov https://github.com/nikivanov

I am adding a feature to play audio from sd card.

I am using the lib mpg123 my-audio.mp3, could I add this lib into the project? if yes I will provide a PR ;)

— Reply to this email directly, view it on GitHub https://github.com/nikivanov/watney/issues/39, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJ45SADQFGTWSQQYPLEIF3YB6TKXAVCNFSM6AAAAAA6WAUHQ6VHI2DSMVQWIX3LMV43ASLTON2WKOZRHE3DQMZVG4YDMMY . You are receiving this because you were mentioned.Message ID: @.***>

eerison commented 11 months ago

I know that I can do this just for my side, I was wondering if make sense I add this feature play audio into your repository.

the idea is list the files from the folder in a dropdown( like the dropdown for choose speak/mic input).

does it make sense to include it here?

Screenshot 2023-10-30 at 14 44 51
nikivanov commented 11 months ago

Sure, just please put it under a feature flag in the config, so it only shows up if it's enabled

eerison commented 11 months ago

Hey Nikivanon, did you have any example for feature flag in JS?

because to enable/disable it, I need to get it in watney.js file, but I did not see any example.

nikivanov commented 11 months ago

No, currently the only feature flag is for the server side feature of off charger re-docking.

On Sat, Nov 4, 2023, 8:27 AM Erison Silva @.***> wrote:

Hey Nikivanon, did you have any example for feature flag in JS?

because to enable/disable it I need to get it in watney.js file, but I did not see any example.

— Reply to this email directly, view it on GitHub https://github.com/nikivanov/watney/issues/39#issuecomment-1793430014, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJ45SEPBLOBE6W5RFDF6CTYCYYEPAVCNFSM6AAAAAA6WAUHQ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJTGQZTAMBRGQ . You are receiving this because you were mentioned.Message ID: @.***>

eerison commented 11 months ago

No, currently the only feature flag is for the server side feature of off charger re-docking. … On Sat, Nov 4, 2023, 8:27 AM Erison Silva @.> wrote: Hey Nikivanon, did you have any example for feature flag in JS? because to enable/disable it I need to get it in watney.js file, but I did not see any example. — Reply to this email directly, view it on GitHub <#39 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJ45SEPBLOBE6W5RFDF6CTYCYYEPAVCNFSM6AAAAAA6WAUHQ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJTGQZTAMBRGQ . You are receiving this because you were mentioned.Message ID: @.>

well as I need to add this feature behind a feature flag, and there isn't anything implemented for frontend, I will close this issue until find any solution for this ;)