soc-se-bot
commented
1 year ago Team's Response
We agree that we made a mistake that we did not handle this case properly. Yet, we do not think that it is a medium severity as this the staff can be deleted to fix the issue even if the user ASSUME that an error would be shown. Hence this is just a minor inconvenience to the user rather than a huge inconvenience.
Furthermore, even if the user added a duplicate staff with a space in the name, the outcome shown to the user is just a Ui bug.
Hence, we decided to accept this bug but lowered the severity to Low instead of Medium.
Items for the Tester to Verify
:question: Issue severity
Team chose [severity.Low]
Originally [severity.Medium]
- [ ] I disagree
Reason for disagreement: [replace this with your explanation]
Improper use of taking inputs.
String.trim() has not been used here, which results in duplicate entries of staff to be able to be added, although there is Ui output which shows if the exact same name without the extra whitespace is being added by the user.
It is medium bug severity since:
say I'm a manager who has used the DinerDirector application for a considerable amount of time and I accidentally add the same staff with an extra whitespace (on the second try) by accident. Having used it for so long, I would ASSUME that it would give me an error message if I tried to add the same thing twice.
It is a functionality bug since I am supposed to get the error output message if I try to add the same name with an extra white space (even UG does not say there cannot be extra whitespace)