nikkisaurus / FarmingBar

4 stars 1 forks source link

[Bug]: Progress notification is off a little when using alt ID with tracker. #61

Open rbpaiett opened 11 months ago

rbpaiett commented 11 months ago

Interface Version

1.14.4

AddOn Version

v3.8.1

Have you replicated this error without any other addons loaded?

Yes

What steps did you take leading up to this issue?

I created a goal with light leather. Then I created an entry for an alt ID for ruined leather scraps. For the multiplier, I put 1/3 (0.333) because it takes 3 scraps to make one leather.

When I got 3 of them, there wasn't an update. However, when I picked up a 4th one, then I got the update for another light leather. Then after that, the update would happen every 3 scraps.

Curiously enough, I was getting Lua errors with the classic & the LK versions but not with the retail version while playing in the Classic Era realm. The retail version works like a charm in Classic Era, strange.

Did you encounter any Lua errors related to this issue? If so, please provide them here.

No Lua errors.

Please supply any screenshots relevant to this issue.

No response

Please supply a copy of your saved variables. You may need to save the file as a .txt file to upload here.

Here's the export for that template:

vsvWUnnqqurdiGkoWfKq90kFO0k5w1sK4qL6H40qveHwiKCavHGnRNuV017AT7SHgH4ch4Cv(e4tGlCKFbl(g6hc76eNsTsOIrwYAM5nJN5TV13AuxLSVbE2KuktRq4CCLiCCge1UxRxoGJqA7dU8IVIAk7mqBw7BrsAk87o8ttqshGIjGoVw(TNOg8rGH8rqTaE8Lx8dUKjSXqdbAskDIOYZ(q2dN5DOLlI9HwDavGTpWS2ZDLg)tF7(EQvG8mbh0V6o7SD961ZVB2J6A5siU8ZsEdttZm53)1rPwesMWuYyoYvY1JgALSZR9l)lFGnkN)qYHa2BQttLvIBUkXzBTfPxc3qCpUotmO2YqRgiQHfbMvobPdeWEZkPSNK9jFUSlo7KDFxLiEZZPUWbEAni0NiOz)UDBDuZ3gubkp2bChNfwjXCk2LF3Qj)l(2LEivyGLaXt53aK5hnlytkStckG8cyCGFBD8fub2xQ26PNXlPHl8J8)rBLMxF6ljiCjawk)wAxP9werxSC)RLDUZuuLzo64ET2JKspZPV8slVUAixBqcvFQnfKOxTvrE6vKsU4AI0srDrofsKadmgQECizG11TruUWRtj8HKXkRMWSguLET6m80mhcQmMeRaJ8jiHLqLNoDS(eDmbOSK56ExfmQGzfueI3E20iuUyewXyUpP6KVX7dll34UsS5vCHgCxTK3iEqgNx7Pn60jI7UyVU7xdpELhiYRf1OFVJ7ICua537pd

Here's the saved variables as well:

FarmingBar.txt

nikkisaurus commented 11 months ago

Just to be clear I'm understanding the issue:

At 3 scraps, no progress alert. At 4, alerts 1 leather. At 7, alerts 2 leather. At 10, alerts 3 leather. Etc.

rbpaiett commented 11 months ago

Yes, correct.

nikkisaurus commented 11 months ago

Completed in version 3.9.0.

See the following message I provided within the addon's help section for more info, as you will need to update your objective:

Sometimes alert progress will be inaccurate when using a tracker's altID. This has been partially remedied in Farming Bar Version 3.9.0, but may require an additional step from you. The issue is caused by previous versions' rounding multipliers to 3 decimal points, which when factored into count calculations results in values less than 1 when it's expected to equal 1 (for example, 1/3 is rounded to 0.333, but when 3 of the item are acquired, the calculations equate to 0.999). Because rounding can result from different ratios (1/75, 1/76, 1/77, 1/78, 1/79, 1/80, for example, all round to 0.013), I've opted not to automatically fix misrounded multipliers. To fix any trackers causing this error, you will need to edit the tracker and reenter the appropriate multiplier ratio. The addon will no longer round the resulting decimal, and alerts should resume as expected. Please remember that any changes to an Objective Template (accessed through the main options frame) will not automatically apply to anything added to a bar. You must manually overwrite the objective on the bar with your updated template or directly edit the objective via the Objective Editor.

rbpaiett commented 11 months ago

Ok, one thing I noticed is with v3.9 the count totals at the bottom right don't match the number in my bank/inventory. This total worked before when I used the retail version on the Classic Era server. Also, the alerts stopped working when I reached the altID amount to add to the tracker progress (like when I get 3/3 of ruined scraps). The alerts then stops for all additions after that.

UPDATE: I will try deleting saved variables and see if that makes a difference.

Ok, deleting the saved variables did make a difference. BTW, the count that I read on all buttons is '1', no matter how many I have in the bank or inventory. When I change back to the old retail version, the counts are correct.

rbpaiett commented 11 months ago

Ok, bottom line, I'm using the 3.81 version for retail and I'm using it on a Classic Era server. I removed the rounding you mentioned and now it all works perfectly :)

I'm not sure what you did with version 3.90 but the progress and alerts and counts weren't working correctly.

nikkisaurus commented 11 months ago

Did this stop all counts working or just counts with altIDs? I just implemented the faction ignore, so that is the only other thing that would affect the counts. By default opposite factions will be ignored, so if you previously had some including another faction, it would look different unless you edit the tracker and select for it to track both.

Also, just to be sure I understand right, when every count is reading 1, did this include items that didn't have altIDs?

rbpaiett commented 11 months ago

Let me check, I have to delete what I have currently and then install the latest to be sure.

rbpaiett commented 11 months ago

Ok, after running some scenarios, I discovered something interesting:

I add Light Leather to one of the bars. It shows in the bottom right just the number 1 and it doesn't change no matter how many I farm. Also it doesn't show any progress on the screen. It's as though I didn't gather anything.

Then I add an altID of Ruined Leather Scraps and same result.

Then as a crazy idea, I thought why don't I add an altID of Light Leather to the same Light Leather button. When I do that, the tally in the bottom right changes but it shows the correct tally+1 and the progress on the screen shows normally. In other words by adding the altID with the same item (Goal of Light Leather 'and' an altID of Light Leather), it works correctly except that it adds 1 to the inventory total.