nikkishri / dropthings

Automatically exported from code.google.com/p/dropthings
0 stars 0 forks source link

Enhancement - Imroving Performance using ReSharper #175

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

Decided to use ReSharper to run code inspection in the entire dropthings 
solution. (tool: http://www.jetbrains.com/resharper/ ).

It returned many suggestions, and wanted to know thoughts on which ones I 
should go ahead and change. They include:

1) lowering scopes to minimum required (like changing public to private when 
possible)

2) making some class properties, constants, method static

3) removing directives from classes that can be safely removed

4) making fields read-only when they can be

5) making some strings localizable

One issue I can think of is less maintainable solution, but have also of course 
googled the performance advantages of most of these.

Original issue reported on code.google.com by darius...@hotmail.com on 12 Jan 2011 at 9:03

GoogleCodeExporter commented 9 years ago
guess there wasn't spelling performance checker for entering subject of this 
issue -- are the actual enhancements to the code as trivial ? or the opposite 
-- monumental ! 

Original comment by darius...@hotmail.com on 12 Jan 2011 at 9:07

GoogleCodeExporter commented 9 years ago
Looking at the points you have found from ReSharper, they don't appear to be 
performance improvement, more like code quality improvement. For ex, making 
properties static. The performance gain you will get from this will be 
immeasurable. Making strings localizable will actually slow down.

Nonetheless these are good suggestions to improve code quality. But if you are 
looking for performance gain, I don't think you will ever be able to measure 
the difference, let alone feel it. 

Original comment by omaralzabir@gmail.com on 13 Jan 2011 at 4:58

GoogleCodeExporter commented 9 years ago
made some of the changes, and RSS feeds do not load. 

spectacular quality i feel, as ReSharper checks for wide range of points and 
those 5) pretty much are all that was found. 

Original comment by darius...@hotmail.com on 13 Jan 2011 at 5:21

GoogleCodeExporter commented 9 years ago
Thanks for the compliment.

Original comment by omaralzabir@gmail.com on 14 Jan 2011 at 5:00

GoogleCodeExporter commented 9 years ago

Original comment by omaralzabir@gmail.com on 19 Jan 2011 at 1:47