nikku / didi

Dependency Injection for JavaScript
MIT License
93 stars 17 forks source link

Installing this repository errors on git bash (Windows) #5

Closed nicojs closed 6 years ago

nicojs commented 6 years ago

Running npm i in the repository errors on windows.

$ git clone git@github.com:nikku/didi.git
$ cd didi
$ npm i

> didi@2.0.1 prepare C:\z\utrechtjs\didi
> run-s bundle

> didi@2.0.1 bundle C:\z\utrechtjs\didi
> NODE_ENV=production rollup -c

'NODE_ENV' is not recognized as an internal or external command,
operable program or batch file.
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! didi@2.0.1 bundle: `NODE_ENV=production rollup -c`

Is the bundle step important to run on as "prepare" script? Can we maybe use cross-env to ensure it works on windows and linux?

nikku commented 6 years ago

I'm using Linux. If you'd like Windows to be supported for building the utility fix things with a PR.