search

nikku / karma-browserify

A fast Browserify integration for Karma that handles large projects with ease
MIT License
321 stars 50 forks source link

Move `watchify` to optionalDependencies? #202

Closed dead-claudia closed 7 years ago

dead-claudia commented 7 years ago

Building off of #193, I think it might be better for it to be listed as an optional dependency. npm will still warn about incompatible versions with optional dependencies, but it won't warn about them not being installed (they're optional, after all). Like peer dependencies, they aren't automatically installed.

dead-claudia commented 7 years ago

Nope...won't work: npm/npm#3066

partounian commented 7 years ago

This is a bit old, but I'm having issues with it as a peerDependency and can't seem to remove that requirement as npm install or yarn will just repull the file and try running that. Any way to get around this issue?

dead-claudia commented 7 years ago

@partounian I'd consult https://github.com/npm/npm/issues/3066 and maybe file an equivalent issue in Yarn's repo, since they are the ones blocking this.

partounian commented 7 years ago

So no workaround just to get this to build?

dead-claudia commented 7 years ago

The workaround is just to npm install --save-dev watchify.