Closed etpinard closed 5 years ago
Ah. Looks like karma@3
dropped support for Node@4.
I should probably revert https://github.com/nikku/karma-browserify/pull/219/commits/aff7a533934bdcfb7cc1a606ab45af8804ea6b89, unless karma-browserify
is ok with dropping Node@4 support.
Edit: [...] is ok with not being tested on Node@4.
I think it would be ok to drop Node 4 support as part of karma@3 compatibility. It's almost certainly more important to test on karma@latest than continue to support karma@2.
If anything a "no WARN logs are printed" test could be nice. If that's too tricky no test against this change is ok too.
@bendrucker thanks for taking a look at my PR!
I should be able to add a test at some point next week.
Cool! Test is far from required and could even be submitted separately. I would be ok merging this now with:
peerDependencies.karma
updatedengines.node
updatedThanks! Published as a major (because of the peer + node version changes).
... instead of
.browserify
to avoid "Invalid file type" logs inkarma@3.1.1
from a patch added in karma-runner/karma#3165Before https://github.com/nikku/karma-browserify/commit/4ef50afa4ae4cf7bbf645a1e1d6a651f49d50738
and after
npm-test.base.txt npm-test.txt
I could of course add a test for this, if deemed necessary.