search

nikku / karma-browserify

A fast Browserify integration for Karma that handles large projects with ease
MIT License
321 stars 50 forks source link

Breaking change coming for karma-browserify/lib/preprocessor.js #228

Closed johnjbarton closed 3 years ago

johnjbarton commented 3 years ago

The monkey patch code in this file will break in the next release of karma.

AFAICT the code is mutating the config to attach browserify-bundle to *.browserify.js? Why?

johnjbarton commented 3 years ago

I found a way to make this work for now.

nikku commented 3 years ago

Which way did you find? Could help others using the tool, too.

More context would also help us to prevent the karma update from breaking our preprocessor, too.

johnjbarton commented 3 years ago

Google's internal build system (open sourced as bazel) supports binding a karma.conf.js with each karma plugin. This has worked well for us. If karma supported this at the nodejs level then your monkey patch would not be needed. It could be as simple as require('<plugin>/karma.conf.js'). WDYT?

nikku commented 3 years ago

I'm lacking the details on what you would like to achieve and why.

If karma-browserify is the cause of any trouble, create a new issue with concrete steps to reproduce.