search

nikku / kartoffeldruck

A all-in-one, opinionated, swiss army knife, hackable static site generator.
Other
6 stars 1 forks source link

Generalize content processing with markdown as default #4

Closed jrehwaldt closed 8 years ago

jrehwaldt commented 8 years ago

An option to add a post-processor would be nice. Basically, there could be a stack of content processors (per extension/glob pattern) with markdown being one of them, but that defeats the goal of an 'intentionally non-pluggable' static site generator. This would enable easy additions, which are not easily covered using nunjucks filters, such as emojis (#6).

Update: Made this issue focus on the generalization and extract the smiley request into #6.

nikku commented 8 years ago

Sounds good. Can yon create a PR on this?

jrehwaldt commented 8 years ago

Going good here :smile: Existing tests are green.

jrehwaldt commented 8 years ago

How do I merge my super duper change now... 23f98f75aef529a1842bb2dfa9bac9a5d737c574

nikku commented 8 years ago

An option (no guarantees): 

# gives you a-commit-hash
git commit ... 
git fetch upstream
git checkout master
git reset --hard upstream/master
# applies your change in a-commit-hash on new master (without history)
git cherry-pick a-commit-hash
jrehwaldt commented 8 years ago

Warum einfach, wenn's auch kompliziert geht...

nikku commented 8 years ago

Git skillz, for da win, wa :wink:

jrehwaldt commented 8 years ago

I didn't see you mention rebase. Skill loss all the way :smile_cat:

nikku commented 8 years ago

:cake:

jrehwaldt commented 8 years ago

+1

nikku commented 8 years ago

PS: https://lefedt.de/blog/posts/2013/contributing-to-oss-through-pull-requests/

jrehwaldt commented 8 years ago

Didn't find it. https://lefedt.de/blog/posts/2016/how-to-handle-subsequent-and-dependent-pull-requests-if-the-oss-author-rewrites-them-when-merging/ ? ;-)

nikku commented 8 years ago

Pluggable content processors are beyond the scope of this project.

There are a lot alternative solutions out there that offer that functionality already, i.e metalsmith that are 100% pluggable.

kartoffeldruck should work out of the box and do only one thing right: Flexible content generation with a powerful templating language in the back (Nunjucks) and a great way to write posts (Frontmatter + Markdown).

nikku commented 8 years ago

Smilies can still be a great feature, just because they make up a great addition for writing blog posts.

jrehwaldt commented 8 years ago

I can see this won't come so I'll close it...

nikku commented 7 years ago

Closed via f89d412.