nikku / node-xsd-schema-validator

A schema (XSD) validator for NodeJS
https://www.npmjs.com/package/xsd-schema-validator
MIT License
51 stars 24 forks source link

support international characters in xml values #11

Closed samzilverberg closed 7 years ago

samzilverberg commented 7 years ago

root problem: I was having problems with umlaut characters in xm values. the xsd validator was considering them to be "??".

I reproduced the problem in a test case and found a quick fix. all that was needed is to read from System.in as UTF-8.

nikku commented 7 years ago

Did not have that problem on my OS, probably because UTF-8 is not the default character encoding on your machine. Merged your PR via 27aa25013140e671f224a33e1da4b369d45b657c.

Thanks for your contribution.

samzilverberg commented 7 years ago

The problem happened on my mac but also on EC2 instance provisioned with an Amazon AMI without any messing with charsets or other defaults. So i'm guessing the problem is more common than just my OS :)

thanks for merging so quickly, could you also npm publish a new version please?

samzilverberg commented 7 years ago

thanks for 0.5.0 👍 (and the extra enhancements you made)