search

nikku / wuffle

A multi-repository / multi-organization task board for GitHub issues.
https://wuffle.dev
MIT License
118 stars 23 forks source link

Filter `reviewer` displays PRs where mentioned person is the author #117

Closed barmac closed 2 years ago

barmac commented 2 years ago

Describe the Bug

When I look for PRs with a specific reviewer, the task board displays also PRs created by that person.

Steps to Reproduce

  1. Open this link: https://tasks.bpmn.io/board?s=ref%3Abpmn-io%2Fbpmn-js-properties-panel%23485
  2. Notice that this issue is displayed: https://github.com/bpmn-io/bpmn-js/pull/1504

Expected Behavior

Only PRs where the person is a reviewer should be displayed.

Environment

nikku commented 2 years ago

Thanks for reporting. Only surfaces since the recent rollout of different colors for commented and requested_for_review. Will look into a fix once I find the time to do so.

nikku commented 2 years ago

This is not a bug, but a feature. You actually did review that PR:

image

To prevent authors from showing up, you may combine the reviewer with the !author qualifier.

nikku commented 2 years ago

What is your expectation for the reviewer filter? I'd assume that most importantly I'd like to have a view that shows in which places I'm requested for review. Not sure how much value the reviewer filter provides.

barmac commented 2 years ago

Indeed, I'd expect the filter to return only issues where in the PR the person was assigned to review. I wouldn't count myself in that case as a reviewer. However, I see that GitHub counted my comment as a review.

To prevent authors from showing up, you may combine the reviewer with the !author qualifier.

Thanks for the hint. I wasn't aware of that useful feature :)