search

nikku / wuffle

A multi-repository / multi-organization task board for GitHub issues.
https://wuffle.dev
MIT License
118 stars 23 forks source link

Clicking Github number does search instead of opening issue #35

Closed joannenolan-sky closed 5 years ago

joannenolan-sky commented 5 years ago

When I click on an issue number, instead of opening the Github issue as it did previously, a search is done on the issue instead. Screen Shot 2019-07-15 at 11 06 15

nikku commented 5 years ago

Is this a feature request or bug report?

You can navigate to the issue via the small GitHub icon or by using your standard browser controls (CTRL or CMD + click will the link in a new tab, bringing you to the GitHub page).

joannenolan-sky commented 5 years ago

A Bug report, as this is a change to current behaviour. It also means I can't click on a link directly I can only search on that link. This is especially irritating if I have searched for an issue in the first place

nikku commented 5 years ago

As mentioned above you can still click on the link just fine. Given that fact, how much of an issue is that for your?

The new interaction is intentional, as it allows you to very quickly drill down into individual issues, check their dependencies and so on. You may always drill up again via HISTORY BACK or the related keyboard shortcut.

joannenolan-sky commented 5 years ago

I think it is useful to have that search feature on the icons as they are usually how you want to search but it is more steps if I want to click on a linked issue as that will only bring me to the search and not the issue itself. For example on a childEpic Icon, instead of on the issue number., have it search using the icon 

 <LinkIcon class="epic" name="epic" onClick={ onSelect && handleSelection('ref', item.key) }/>
nikku commented 5 years ago

I've heard this feedback on direct clicking from a number of places right now.

While I'm not a fan of silencing the default browser click + modifier behavior I'm also aware of the implications of not being able to navigate to GitHub easily for non-keyboard users.

https://github.com/nikku/wuffle/commit/7c62a0022d7239e0cc4e5e68af33fd9cc227cb69 reverts to the requested, old behavior. In order to filter the board, users must press CTRL (to apply filter) or SHIFT (add as filter criteria).

Happy to hear your thoughts on this change.

nikku commented 5 years ago

Released as v0.20.0.