search

nikku / wuffle

A multi-repository / multi-organization task board for GitHub issues.
https://wuffle.dev
MIT License
118 stars 23 forks source link

Support github's full array of closing keywords #71

Closed jjlankinen closed 4 years ago

jjlankinen commented 4 years ago

Is your feature request related to a problem? Please describe.

Currently Wuffle board only supports 2 Github's closing keywords which are closes and fixes and it would be nice to actually get this board to integrate into the Github better by adding support for the rest of the keywords also.

Describe the solution you'd like

I would like to see every Github's closing keywords supported which are described here: https://help.github.com/en/articles/closing-issues-using-keywords

Describe alternatives you've considered

If this is too much of work and it's decided not to follow full keyword support then alternative is to force team members and collaborators to suck it up and force them to change their keyword usage habits which can be a bit problematic as unknown collaborators need to know which keywords can be used.

nikku commented 4 years ago

I'm fine supporting the full range of closing keywords. :+1:

mjcarroll commented 4 years ago

Waffle also support connects to and connected to for a parent-child relationship.

@jjlankinen: I believe the place to update for all of those would be here: https://github.com/mjcarroll/wuffle/blob/0ed57f7202a25d47df3a50b3788142d7fb65f2cb/packages/app/lib/util/links.js#L8

nikku commented 4 years ago

I personally don't like the connects and connected to it is highly ambiguous.

For the closes hints, I'm happy to accept a PR that contributes the improvements.

nikku commented 4 years ago

Waffle also support connects to and connected to for a parent-child relationship.

I reconsidered my opinion here. The keywords are cryptic enough so that they probably do not cause confusion. Likely no-one except for a former Waffle user are using these. If they matter to you, file a PR and I'll accept it as a contribution.

nikku commented 4 years ago

Released with v0.28.0. Special thanks to @mjcarroll for contributing this improvement.