search

nikku / wuffle

A multi-repository / multi-organization task board for GitHub issues.
https://wuffle.dev
MIT License
118 stars 23 forks source link

Support full list of GitHub keywords #73

Closed mjcarroll closed 4 years ago

mjcarroll commented 4 years ago

Closes nikku/wuffle#71

mjcarroll commented 4 years ago

As an additional question here, should this support the keywords with a colon? For examples Fixes: #71 vs Fixes #71. It does not appear that it currently supports this capability.

nikku commented 4 years ago

As an additional question here, should this support the keywords with a colon? For examples Fixes: #71 vs Fixes #71. It does not appear that it currently supports this capability.

What's your thought? I personally find it odd to use colons here but I see people doing it. So why not support / recognize that one, too.

mjcarroll commented 4 years ago

I think since Github supports it, it probably makes sense to support here as well.

mjcarroll commented 4 years ago

Added support for the colon. Feedback welcome. I originally attempted doing the close|closes|closed match with another group like (close(s|d)?) but it makes the match extraction logic break below, so simple seemed better.

If there are tests somewhere else that need to be updated, let me know, this seemed to be the right location.