search

niklabh / mattermost-plugin-webrtc-video

A webrtc video call plugin for mattermost
Apache License 2.0
84 stars 17 forks source link

Don't fallback to default stun/turn servers if they are configured #46

Closed ghost closed 3 years ago

ghost commented 3 years ago

If you configure stun and turn server the hardcoded fallbacks are still used the configured settings only added to the iceServers array see:

https://github.com/niklabh/mattermost-plugin-webrtc-video/blob/e3513a33a52de9c2b84f1d98d400c6d7a702b17a/webapp/src/actions/index.js#L123-L135 and https://github.com/niklabh/mattermost-plugin-webrtc-video/blob/e3513a33a52de9c2b84f1d98d400c6d7a702b17a/webapp/src/components/modals/audio_group_call/audio_group_call.jsx#L150-L162

I have set up stun and turn server for this and don't want to use any external services. Do you prefer an extra config option for this or just drop the default config if any stun/turn server is configured?