search

niklasb / dryscrape

[not actively maintained] A lightweight Python library that uses Webkit to enable easy scraping of dynamic, Javascript-heavy web pages
http://dryscrape.readthedocs.io/
MIT License
533 stars 67 forks source link

python3 support issure #28

Closed a358003542 closed 9 years ago

a358003542 commented 9 years ago
  1. the dryscape init.py
    line 1 from .session import recommend not use the relative represitation from dryscrape.session import import dryscrape.driver
  2. the dryscape session.py line 1 import urlparse changed to from urllib.parse import urlparse,urljoin

and the line 34 return urlparse.urljoin(self.base_url, url)

changed to return urljoin(self.base_url, url)

  1. the dryscrape mixins.py line 100: raise WaitTimeoutError , "wait_for timed out" changed to raise WaitTimeoutError("wait_for timed out")

  2. this is webkit_server issue for python3

https://github.com/niklasb/webkit-server/issues/15

now it can run under python3 .

niklasb commented 9 years ago

This should be resolved via https://github.com/niklasb/webkit-server/commit/574b1d35ff66c8669f400de21d193d5887bf8ec3 and https://github.com/niklasb/dryscrape/commit/214446f5f89a29c8a600034a7b2f8af5a3164cf1