search

niklasb / dryscrape

[not actively maintained] A lightweight Python library that uses Webkit to enable easy scraping of dynamic, Javascript-heavy web pages
http://dryscrape.readthedocs.io/
MIT License
533 stars 67 forks source link

Added dryscrape.stop_xvfb() function #34

Closed trendsetter37 closed 9 years ago

trendsetter37 commented 9 years ago

This may be useful when using dryscrape in a python console or if dryscrape is only needed in a small portion of an application thus requiring an explicit stop function.

niklasb commented 9 years ago

Did you mean to include the .egg-info directory? I don't think it should be part of the repository

trendsetter37 commented 9 years ago

No I didn't mean to do that :(

niklasb commented 9 years ago

Great :) Thanks for the idea and for implementing it!

trendsetter37 commented 9 years ago

So do I close this pull request and just submit a new one?

niklasb commented 9 years ago

Thanks. No you don't need to open a new pull request, the old one is updated automatically as you push into the same branch.

trendsetter37 commented 9 years ago

Ahh ok. I see now.