Downloading of libc packages fails quietly rather than dying

niklasb / libc-database

Build a database of libc offsets to simplify exploitation

https://libc.rip/

MIT License

1.68k stars 193 forks source link

Downloading of libc packages fails quietly rather than dying #42

Closed mariuszskon closed 3 years ago

mariuszskon commented 3 years ago

Closes https://github.com/niklasb/libc-database/issues/41

I don't really know bash scripting so the code might not be ideal :sweat_smile:

niklasb commented 3 years ago

can you clarify what the implications of this are w.r.t. https://github.com/niklasb/libc-database/issues/43?

mariuszskon commented 3 years ago

can you clarify what the implications of this are w.r.t. #43?

I do not believe that this PR causes the bug in #43, but rather it lets the downloader progress far enough that that issue is reached. This PR fixes timeouts regarding downloading a single particular libc instance, not touching anything else, while #43 is about getting the package locations for a "family" of libc afaik.

niklasb commented 3 years ago

thanks for analyzing this bug, I addressed it in 460851d300b802f71e9ef1ba4a9f5080ff7f4c37 along with #43

mariuszskon commented 3 years ago

Cheers