niklasb / webkit-server

[not actively maintained] The C++ webkit-server from capybara-webkit with useful extensions and Python bindings
MIT License
48 stars 38 forks source link

Building on OSX #10

Closed jpz closed 10 years ago

jpz commented 10 years ago

I found (for me) the setup.py didn't work.

qmake needed the additional "-spec macx-g++" parameter.

This can alternatively be controlled with "export QMAKESPEC=macx-g++" prior to running setup.py.

I just wanted to pop this feedback to you, it may be worth putting a line on this, in the build process for mac users, or perhaps automating it in the setup.py for the specific platform.

This was Qt 4.8.6 btw on OSX 10.9.4 (have the latest Xcode, etc).

kind regards

niklasb commented 10 years ago

Thank you for bringing this up. Unfortunately I don't have a Mac OS X available for testing, but if you provide a pull request that is verified on your own Mac machine I would be happy to include your suggestion. I was thinking something like

QMAKE_ARGS=
if [ "$(uname)" == "Darwin" ]; then
  QMAKE_ARGS='-spec macx-g++'
fi
qmake $QMAKE_ARGS && ...
niklasb commented 10 years ago

That is for the build.sh script. The same would have to be included in setup.py, probably using a check like platform.system() == 'Darwin'

jpz commented 10 years ago

Ok, will do. Will get back to you shortly.

cheers

On 11 Aug 2014, at 18:10, Niklas Baumstark notifications@github.com wrote:

That is for the build.sh script. The same would have to be included in setup.py, probably using a check like platform.system() == 'Darwin'

— Reply to this email directly or view it on GitHub.