search

niklasb / webkit-server

[not actively maintained] The C++ webkit-server from capybara-webkit with useful extensions and Python bindings
MIT License
48 stars 38 forks source link

Porting to new capybara-webkit #7

Closed JonesChi closed 9 years ago

JonesChi commented 10 years ago
  1. HEAD of capybara-webkit: f35e2df0df3b2e253d78ab96afa670662f862037
  2. Porting commands: SetAttribute, SetHtml, Wait, Evaluate
  3. Remove commands: SetViewportSize, SetErrorTolerance, Source
  4. New commands: IgnoreSslErrors, ResizeWindow, SetSkipImageLoading
  5. Extra command to set attached file directly: SetAttachedFile
niklasb commented 10 years ago

Wow, what a HUGE patch! Thanks a lot for your efforts! I will have a deep look at this, write some tests and try to merge this as soon as possible. Hopefully it won't take me too long to get into this, but I cannot make any promises... I hope you understand :)

Thanks again!

JonesChi commented 10 years ago

Hi, The huge patch is from the upstream (capybara-webkit), thanks capybara-webkit. I just put the new capybara-webkit to src, and porting the commands you added, and add some new commands.

niklasb commented 10 years ago

@JonesChi: I understand that, but I will still have to look through all the code and write tests to ensure that everything that worked before still works :)

niklasb commented 10 years ago

I merged upstream manually, so I think this is fixed. I didn't include SetAttachedFile.