search

niklasf / python-agentspeak

A Python-based interpreter for the agent-oriented programming language JASON
GNU General Public License v3.0
48 stars 24 forks source link

Add askHow, tellHow, untellHow and unachieve illocutions. #15

Closed javipalanca closed 11 months ago

javipalanca commented 1 year ago

Some illocutions to ask for a plan, tell a plan or untell a plan have been added. Some examples were also written to illustrate this. PEP8 styling applied to some files.

niklasf commented 1 year ago

Thanks! Looks mostly good, but I don't like how annotations are parsed, but then converted back to strings and parsed again at runtime, with ad-hoc string searches and slicing.

javipalanca commented 1 year ago

Thanks @niklasf We'll work in fixing this as soon as posible.

javipalanca commented 1 year ago

Hi @niklasf Please, would you check if this version meets better the quality criteria of the project? If so, it would be ready for the merge.

javipalanca commented 1 year ago

this is just a kind reminder :)

javipalanca commented 1 year ago

Hi @niklasf Check if these commits match your quality requirements. If you need more changes don't hesitate to ask! Thanks.

javipalanca commented 1 year ago

Dear @niklasf , Just another kind reminder :) Do you think it would be possible to review these changes in a not too distant future? It would be very interesting for us to be able to release a new version of this package to integrate it in our multi-agent system. Thank you very much!