niklasf / shakmaty

A Rust library for chess and chess variant rules and operations
https://docs.rs/shakmaty
GNU General Public License v3.0
210 stars 41 forks source link

Make `PlayError` fields public #80

Closed tigerros closed 2 months ago

tigerros commented 2 months ago

The private fields are a bug. You can't access the move which was illegal, only the position with into_inner. This PR makes the fields public and removes the redundant into_inner function.

niklasf commented 2 months ago

Thanks! Cherry-picked making the field public. Removed IDE-specific .gitignore entry, using deprecation instead of method removal, and m for move by naming convention of this library.