search

niklasfasching / go-org

Org mode parser with html & pretty printed org rendering. also shitty static site generator.
https://niklasfasching.github.io/go-org/
MIT License
353 stars 48 forks source link

Refresh test fixtures for chroma v2.5.0 #100

Closed anthonyfok closed 1 year ago

anthonyfok commented 1 year ago

tabindex="0" was removed from <pre> elements in chroma v2.5.0; see alecthomas/chroma#736

niklasfasching commented 1 year ago

how are you using this? i.e. should i tag a new release later?

anthonyfok commented 1 year ago

how are you using this? i.e. should i tag a new release later?

Hi @niklasfasching, thank you for your kind gesture! I am just using it for Debian packaging where golang-github-alecthomas-chroma-v2-dev, i.e. alecthomas/chroma/v2, will be at v2.5.0 (due to Hugo v0.111.x), but it was easy enough to patch the Debian package golang-github-niklasfasching-go-org and I already did at:

https://salsa.debian.org/go-team/packages/golang-github-niklasfasching-go-org/-/blob/debian/sid/debian/patches/0001-Refresh-test-fixtures-for-chroma-v2.5.0.patch

That patch is all I need to get the package into Debian. As Debian developers, we are encouraged to contribute our patches upstream, hence this pull request.

And, just like #84, there is no need for you to tag a release right away (unless you really, really wanted to :grin:). No explicit upstream tagged release is needed on the Debian side, but that thank you for your kind gesture!

Cheers, Anthony

niklasfasching commented 1 year ago

cool, thx so much for the detailed explanation :)!