Class feedback-highlighted won't go away when the feedback is closed

niklasvh / feedback.js

Feedback form with screenshot

http://experiments.hertzen.com/jsfeedback/

Other

870 stars 196 forks source link

Class feedback-highlighted won't go away when the feedback is closed #26

Open gauravmishr opened 11 years ago

gauravmishr commented 11 years ago

I am facing this in the Firefox 23.0, fine in FF22.0 & for chrome 28.0.1500.72 m it is also fine.

The concern is with canvas tag highlighted area, which won't go/fade away. while clicking on close button of the send feedback. untitled which is leaving box-shadow patches on the screen..

and i noticed there is one white space, ahead of the class feedback-highlighted.

Kwopr commented 10 years ago

Hi, Here is the why:

http://whereswalden.com/2013/08/05/new-in-firefox-23-the-length-property-of-an-array-can-be-made-non-writable-but-you-shouldnt-do-it/

And, here is a fix:

Go to Core.js, find the removeElements() function (line 10),
Replace this line: var item = Array.prototype.pop.call( remove ); to: var item; if ( remove instanceof HTMLCollection ) item = remove[0]; else item = Array.prototype.pop.call( remove );

simplenotezy commented 10 years ago

Thank you Kwopr!

gauravmishr commented 10 years ago

Thank you @Kwopr! working fine with the same.

luksha commented 10 years ago

Great! Thank you!