search

niklasvh / html2canvas

Screenshots with JavaScript
https://html2canvas.hertzen.com/
MIT License
30.48k stars 4.8k forks source link

Resolve that box shadow cannot be displayed without inset attribute,and No blur effect when blur radius is set #3110

Open KkkkYL opened 1 year ago

KkkkYL commented 1 year ago

Resolve that box shadow cannot be displayed without inset attribute and has no blur effect when blur radius is set.

version 1.4.1

(I must say that this is not a perfect effect, and there is still a slight difference between the shadow style and the actual style.)

berfore:

old hidden old visible

now:

new hidden new visible
Sharcoux commented 1 year ago

Hey, I'm trying to get promising PRs to be merged. Can you check my review? Some parts are uncleared to me but I have meny PRs to review so I didn't dig too deep into it. Don't hesitate to comment.

Sharcoux commented 1 year ago

Can be tested in @cantoo/html2canvas

KkkkYL commented 1 year ago

Okay, I will modify the unreasonable code.

KkkkYL commented 1 year ago

@Sharcoux Is it okay now?

Sharcoux commented 1 year ago

Actually I can't merge in this repo, but I released @cantoo/html2canvas that includes your change. You can test it and use it if you need.

KkkkYL commented 1 year ago

ok!