niknow / TaskArena

A tool adding collaborative functionality to TaskWarrior.
GNU General Public License v2.0
7 stars 1 forks source link

Sundry little fixes #2

Open WenceslaoGrillo opened 8 years ago

WenceslaoGrillo commented 8 years ago

io.py line 47 (in function get_input) replace "input" with raw_input: data = raw_input(msg)

io.py line 59 (in _set_configfile_name) replace \ (Windows???!!!!) with /. self._configfile_name = os.path.expanduser("~") \

Documentation: during install there is no need to mv arenacmd.py /usr/local/bin/tarena Because: python setup.py install already does that, so after that you are already ready to use tarena

niknow commented 8 years ago

Hi,

thanks a lot for your contribution. Regarding your points:

1) input The function raw_input is a Python 2 function, which was replaced by the Python 3 function input because support of Python 2 was dropped in 3ea1afe0cace2872fd2294ad6d733a4908272827

2) Paths That's actually a good point. I replaced this in my last commit 67ae12d by the platform independent os.path.join. This problem occurs also at a few other locations in the code and is now hopefully fixed. (The unittests now fail, but I think this is related to another issue with the test infrastructure. I have to investigate this in more detail anyway.)

3) Documentation The documentation is indeed outdated and needs a complete revision.

WenceslaoGrillo commented 8 years ago

Hi Nikolai, thanks to you for this software! Looks like it's time for me to stop waiting for wxpython support and update to Python 3 anyway! :) But TaskArena is running on my boxes very happily on Python 2.7, where input exists but interprets the input, so you need the inverted commas. Isn't there some kind of #!/bin/python3 missing somewhere, to make it look for Python 3 instead? Regards:

     Wences

On 07/08/2016 09:40, Nikolai Nowaczyk wrote:

Hi,

thanks a lot for your contribution. Regarding your points:

1) input The function |raw_input| is a Python 2 function, which was replaced by the Python 3 function |input| because support of Python 2 was dropped in 3ea1afe https://github.com/niknow/TaskArena/commit/3ea1afe0cace2872fd2294ad6d733a4908272827

2) Paths That's actually a good point. I replaced this in my last commit 67ae12d https://github.com/niknow/TaskArena/commit/67ae12d238e6d116c11a0ddd46d7bb192821f486 by the platform independent |os.path.join|. This problem occurs also at a few other locations in the code and is now hopefully fixed. (The unittests now fail, but I think this is related to another issue with the test infrastructure. I have to investigate this in more detail anyway.)

3) Documentation The documentation is indeed outdated and needs a complete revision.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/niknow/TaskArena/issues/2#issuecomment-238080242, or mute the thread https://github.com/notifications/unsubscribe-auth/AGG2bKd8T1jNge9g5GfvdQYC7yxQEPFaks5qddJPgaJpZM4Ja9aD.

niknow commented 8 years ago

Hi Wenceslao,

glad you like it. Bear in mind it's an early alpha though. ;)

It could very well be that most of it still works under Python 2, I just don't explicitly check for this to streamline development. It currently doesnt use a shebang, but if you

python setup.py install

it, then it depends on your system configuration if python refers to your Python 2 or Python 3. In some Linux environments you can use python3 setup.py install to explicitly enforce Python 3 I think.