search

nikochiko / cool-algos

A repository for algorithms written in several languages
GNU General Public License v3.0
0 stars 10 forks source link

Added selection sort in c++ #31

Closed pareek-naren closed 4 years ago

pareek-naren commented 4 years ago

Added selection sort in c++

pareek-naren commented 4 years ago

@nikochiko Thanks for sharing valuable suggestion. I've updated the changes, please review.

pareek-naren commented 4 years ago

@nikochiko Great, I'll do it with vectors as well. It doesn't take much time. Please suggest a few things: I think we should have a new file with the name vectors_selection_sort.cpp so we can have multiple examples of selection sort in c++. Also, should I raise a new PR for that or implement in the same PR.

nikochiko commented 4 years ago

I think it's okay to have only one for C++. Vectors and standard arrays are not that different anyways so just edit the same file. Do it in this same PR

pareek-naren commented 4 years ago

@nikochiko Updated the Same PR, Please review.

pareek-naren commented 4 years ago

Thanks, @nikochiko for approving the changes. Also, add the hacktoberfest topic in the repo to make it a part of HacktoberFest

nikochiko commented 4 years ago

Yes. I have given it some thought and decided that it would be best if this repository is not included for hacktoberfest after this. The subject of my repo promotes a lot of plagiarism. Almost all of the PRs I received were copy-pasted from some other source. It will be much better for newbie contributors to work on a bigger repository in which they go through the challenging part of writing merge-able code and thinking by themselves.

Also, the contributions you had made so far will still count. Since I haven't taken any PRs after the rules changed, all PRs which have been approved or merged will be accepted

nikochiko commented 4 years ago

merged in https://github.com/nikochiko/cool-algos/pull/32