nikoheikkila / pwnedapi

Library for easily interfacing with Have I Been Pwned API v2

https://pypi.org/project/pwnedapi/

MIT License

9 stars 5 forks source link

Mock api #7

Closed shadetree01010100 closed 5 years ago

shadetree01010100 commented 6 years ago

resolves #4

nikoheikkila commented 6 years ago

Hi, thanks for PR.

You'll need to have the responses library listed in the Pipfile so it gets automatically installed. If you are not familiar with pipenv there's a great documentation of it here. Basically, you would just do pipenv install responses --dev on terminal and everything is set up for you.

When the Travis build goes green I'll get back to this.

shadetree01010100 commented 6 years ago

I've used pipenv, I'll get that updated, and it looks like I need to do a rebase. probably won't be til Monday. Thanks!

codecov[bot] commented 6 years ago

Codecov Report

Merging #7 into master will not change coverage. The diff coverage is 100%.

@@          Coverage Diff          @@
##           master     #7   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           4      4           
  Lines          99    100    +1     
=====================================
+ Hits           99    100    +1

Impacted Files	Coverage Δ
pwnedapi/utils.py	`100% <ø> (ø)`	:arrow_up:
pwnedapi/Password.py	`100% <100%> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3923e98...058f321. Read the comment docs.

shadetree01010100 commented 6 years ago

@nikoheikkila finally got it, sorry for the excessive build triggers!

shadetree01010100 commented 5 years ago

I thought about it for a while, and realized that the check for ujson probably isn't needed anyway since this should be run from within the virtualenv.

nikoheikkila commented 5 years ago

I thought about it for a while, and realized that the check for ujson probably isn't needed anyway since this should be run from within the virtualenv.

It might be wise. Anyone can file an issue to this repo if they encounter this problem, anyway.

nikoheikkila commented 5 years ago

I've approved the changes. Can you now make the build pass and we can merge? Commits will be squashed so don't worry about it.

I also noted the pytest warnings in Travis raising DeprecationWarning which is not severe. If you want to, please check the Responses library if there's any fixes for it or will it be addressed sometime soon.

shadetree01010100 commented 5 years ago

Sure thing. Thanks!