nikoksr / notify

A dead simple Go library for sending notifications to various messaging services.
MIT License
2.79k stars 203 forks source link

Add service/mail header and recover from service panic #695

Closed heilmela closed 1 month ago

heilmela commented 10 months ago

Description

Used Postmark with service/mail. Postmark uses the X-PM-Message-Stream header to select a message stream via header. Currently its not possible to set headers. Furthermore the service/mail did panic when encountering some missing TLS port issues, which leads to waiting for the service routines call to hang until context deadline, which might be undesirable in some cases.

I would suggest adding the recover and error handle for the corresponding service. I know recovering is debatable but the hanging because of one service seems undesirable.

@nikoksr wdyt ?

How Has This Been Tested?

Types of changes

Checklist: