search

nikolalsvk / render_async

render_async lets you include pages asynchronously with AJAX
https://rubygems.org/gems/render_async/
MIT License
1.08k stars 75 forks source link

preventDefault() in toggle code interferes with other UI functionality #109

Closed vanboom closed 4 years ago

vanboom commented 4 years ago

I have a tabbed interface where I would like to kick off the render async when the user selects a tab. The tab system is built using a radio and HTML/CSS only.

I can attach render_async toggle selector to the ID of the radio button that controls the tab switching, but preventDefault() is keeping the default radio behavior from happening.

I am proposing that the preventDefault() be removed from _request_jquery.js.erb:105. So far in my app I have not found any negative ramifications of doing so.

Thanks for all you guys do on this gem.

nikolalsvk commented 4 years ago

Closed in https://github.com/renderedtext/render_async/pull/110

nikolalsvk commented 4 years ago

This is resolved in 2.1.6. Let's reopen it in case it's not!