#106 Add polling control start/stop events

nikolalsvk / render_async

render_async lets you include pages asynchronously with AJAX

https://rubygems.org/gems/render_async/

MIT License

1.08k stars 75 forks source link

#106 Add polling control start/stop events #119

Closed vanboom closed 4 years ago

vanboom commented 4 years ago

In an attempt to gain more control over the start and stop of polling. I have added two events: async-start, async-stop for your consideration.

nikolalsvk commented 4 years ago

Hey, @vanboom, can you rebase this branch with master, please?

vanboom commented 4 years ago

Ok, I think I did that right ;)

nikolalsvk commented 4 years ago

Thanks for this, @vanboom. Sorry for nitpicking, but could you squash your commits to have more descriptive commit messages. Right now we have 14 commits and they are doubled from what I see.

vanboom commented 4 years ago

Ok, I think I did that correctly. Muddling a bit through lack of experience with PRs, thanks for being gracious with these.