search

nikolalsvk / render_async

render_async lets you include pages asynchronously with AJAX
https://rubygems.org/gems/render_async/
MIT License
1.08k stars 75 forks source link

Configurable AJAX method, headers and body #52

Closed reneklacan closed 6 years ago

reneklacan commented 6 years ago

This PR allows render_async to use POST (or any other method) for control. For example, it can be useful when a length of parameters is potentially too long.

reneklacan commented 6 years ago

@nikolalsvk any plan to merge this?

pviral commented 6 years ago

just came across 414 bug which requires me to use POST in render_async and was thinking to contribute but see this PR. Do you guys know when you will merge this PR?

nikolalsvk commented 6 years ago

@pviral thanks for commenting!

Do you guys know when you will merge this PR?

I can't tell you the exact date, but I'm looking forward to see this pushed 🤞. The main thing blocking this feature is support for plain JavaScript. This PR covers the jQuery part of the gem, which is awesome 🤘, but we will also need to support vanilla JS part.

If you or someone else is interested in contributing, just let me know by opening a PR or commenting here 🙂

nikolalsvk commented 6 years ago

I've just released these changes and changes for Vanilla JS part of the gem 🎉

https://rubygems.org/gems/render_async/versions/2.0.0

If you want, you can test it out and report any bugs/issue you come across :)