nikolamilosevic86 / owasp-seraphimdroid

OWASP Seraphimdroid is an open source project with aim to create, as a community, an open platform for education and protection of Android users against privacy and security threats.
https://www.owasp.org/index.php/OWASP_SeraphimDroid_Project
GNU General Public License v3.0
65 stars 31 forks source link

Package Path problem solved #40

Closed bohrium272 closed 8 years ago

bohrium272 commented 8 years ago

Package Path issue mentioned in Issue #32. It wasn't causing any bugs or anything but I was having problem in imports sometimes.

thewayofknowing commented 8 years ago

Please review the comments carefully and maybe after you've handled all the issues you can send another patch. This code can't be pulled in.

bohrium272 commented 8 years ago

Apologize for the inconvenience. How do I carry out tests, as you mentioned, to ensure this doesn't happen again ? I did run the app once to make sure it doesn't crash.

athos-ribeiro commented 8 years ago

I believe it would be nice to start writing a test suite for the project

thewayofknowing commented 8 years ago

That is a good suggestion, we should definitely write out some unit tests. @nikolamilosevic86