search

nikolaos-siomos / ATLAS

Automated Lidar Analysis Software (ATLAS). A piece of software designed for the analysis of lidar data in an automated fashion and with focus on the following Quality Assurance tests: Rayleigh Fit, Telecover, Depolarization Calibration. Quicklook generation is also supported
GNU Affero General Public License v3.0
4 stars 7 forks source link

1058 rotational Raman too large wavenumber shift #11

Open hoferj86 opened 9 months ago

hoferj86 commented 9 months ago

Running ATLAS v0.4.6 with a rotational Raman channel at 1058 nm does not work anymore. With previous versions, we ran this channel with nomenclature 1058frpx (subject to change, though. For channel type "r", channel suptype "x", "l", or "h" would be possible). Now, the following errors occur for all these possible subtypes:

too_large_wavenr_shift_h too_large_wavenr_shift_l too_large_wavenr_shift_x

I took a look at \processor\arc\atmosphere.py, line 96-102. For ewl_ch = 1064 and dwl_ch = 1058, wns_ch = 1E7 * (1. / ewl_ch - 1. / dwl_ch ) yields -53.2996. So changing \processor\arc\atmosphere.py, line 101 from if ch_type.loc[ch] == 'r' and (np.abs(wns_ch) > 500 or wns_ch < -50): to if ch_type.loc[ch] == 'r' and (np.abs(wns_ch) > 500 or wns_ch < -54): solved this issue for me. But since I don't know on what this criterium is based, I am not sure if this change would be valid.

nikolaos-siomos commented 7 months ago

This issue should have been fixed by the new version 0.4.7. Could you verify it?