Styling the main page to be responsive

nikomakr / studyingShowTime

project1

MIT License

1 stars 0 forks source link

Styling the main page to be responsive #77

Closed clamadi closed 6 months ago

clamadi commented 6 months ago

Description / User Story:

We need to style the page and make it responsive such that the paged can be viewed on different screen sizes without being distorted.

Acceptance Criteria: When the page can be viewed on any screen size without being distorted.

QA (quality assurance) / testing:

All the above met.

nikomakr commented 6 months ago

Hi @clamadi,

You made changes to three files:

style.CSS [Everything looks good]
index.html [Code looks good, but after testing the page the navbar doesn't look good. Rest of page is nicely responsive. From acceptance criteria I wasn't sure if the responsiveness applies to only one part.]
searchpage.html [You changed the js file, which is not right.]

For the moment we can accept this if navbar is not part of the work here, but searchpage.html has wrong link of js!

nikomakr commented 6 months ago

Responsiveness of mainpage, here:

[](url)

nikomakr commented 6 months ago

searchpage.html wrong js link pushed:

[](url)

clamadi commented 6 months ago

hi Niko @nikomakr , I made changes to the nav bar to display column instead of row when in smaller scree as the collasible wrapper on the nav bar wasn't working and we couldn't get it to work while i was on with my tutor.

you can confirm this from the API branch 37.

kind regards chiamaka

clamadi commented 6 months ago

for the search html page I didn't realise a code was changed. i will compare that with the 37-API branch and revert changes. Apologies on this.

nikomakr commented 6 months ago

OK all good @clamadi I merged it to the main.