search

nikosarcevic / CosmOracle

https://share.streamlit.io/nikosarcevic/cosmoracle/main
GNU General Public License v3.0
22 stars 2 forks source link

CosmOracle redirect not working properly #64

Closed lonbar closed 2 years ago

lonbar commented 2 years ago

For whatever reason www.cosmoracle.com isn't redirecting properly anymore. The link in the README still works, so the problem is not cosmoracle itself. We should check whether anything has changed

lonbar commented 2 years ago

A quick search suggests to me that this issue may be caused by Streamlit's recent rollout of custom subdomains. The blog post mentions that the release was scheduled for 21 July. This is backup up by @nikosarcevic's first noticing the bug around 22 July. Furthermore, other Streamlit apps that have been embedded in the way ours is have similar redirecting issues (see e.g. this one and the discussion about custom domains on Streamlit's discuss page). Other pages that have originally been embedded have now been moved to the new domain naming scheme, such as this one.

EDIT: I am now convinced that the new subdomains are the cause of the issue, see this discussion. I am not sure if this issue has since been resolved.

lonbar commented 2 years ago

After carefully reading the announcement about subdomains again, I managed to fix the issue by changing the URL in the iframe element of our GitHub page. See commits 543acc5 and 782fa97. I am not sure if this is a lasting solution (In this discussion it seems to have brought on additional issues)) and we will eventually have to come back one Streamlit finishes their custom URL roadmap.