nikosbosse
commented
2 years ago Nice, thank you very much! Looking good.
Whether or not there should be a requirement of a number of forecasters is an interesting question. With the requirement in place I think it makes sense to also leave the chart (shows uncertainty) and just treat it as a valid forecast that is reported.
Without the requirement this would probably rather be an announcement "hey, there is a new question you can predict on". And if the requirement is not met it probably wouldn't show the current community prediction and also no chart.
We could even have both? What do you think @edomt, @adam-binks?
I removed the check within p.is_question_included that checks to see if the question was created within the last 48 hours and added that within p.get. I also changed p.add_tweet so now it has an alert_type parameter with slightly different logic depending on whether alert_type = "New" or "Swing"
Notes: I haven't tested with the Twitter API Maybe new question tweet alerts shouldn't include the graph, possibly should be a different template for that type of tweet I left in the check about having a minimum number of forecasts -- even new questions must satisfy that